RFR: 8286597: Implement PollerProvider on AIX [v2]
Richard Reingruber
rrich at openjdk.org
Tue May 9 07:43:24 UTC 2023
On Mon, 8 May 2023 16:41:21 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
>> src/hotspot/cpu/ppc/continuationHelper_ppc.inline.hpp line 50:
>>
>>> 48:
>>> 49: inline void ContinuationHelper::update_register_map_with_callee(const frame& f, RegisterMap* map) {
>>> 50: // Nothing to do
>>
>> Would it be better to call the empty `frame::update_map_with_saved_link` to be consistent with the other platforms? @reinrich: You may have an opinion.
>
> I thought about doing that, but decided to save the call. Now that you mention it, it would probably be a good idea to at least explain this in the comment. I will also wait to see what Richard suggests.
I'd prefer this version. It is clearer about the fact that `map` doesn't need to be updated on ppc with data from the callee `f`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13452#discussion_r1188254926
More information about the nio-dev
mailing list