RFR: 8286597: Implement PollerProvider on AIX [v4]
Tyler Steele
tsteele at openjdk.org
Thu May 11 14:08:48 UTC 2023
On Thu, 11 May 2023 05:31:18 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Tyler Steele has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Improve comment in ContinuationHelper procedures
>> - Completes removal of include from adlc/main.cpp
>
> test/jdk/java/lang/Thread/virtual/stress/Skynet.java line 28:
>
>> 26: * @summary Stress test virtual threads with a variation of the Skynet 1M benchmark
>> 27: * @requires vm.continuations
>> 28: * @run main/othervm/timeout=350 -Xmx1g Skynet
>
> I assume this should be dropped from this PR as it is nothing to do with implement the AIX version of PollerProvider.
Agreed. It feels funny to push code I know will cause a test failure. But, I agree that it simplifies the git history, and aligns with the stated purpose of this PR. Thanks for the suggestion. I have made this change.
> test/jdk/java/net/vthread/BlockingSocketOps.java line 62:
>
>> 60:
>> 61: import jdk.test.lib.thread.VThreadRunner;
>> 62: import jdk.test.lib.Platform;
>
> This seems to be left over from one of your previous iterations.
Thanks for catching that. I made this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13452#discussion_r1191225354
PR Review Comment: https://git.openjdk.org/jdk/pull/13452#discussion_r1191225751
More information about the nio-dev
mailing list