RFR: 8307409: Refactor usage examples to use @snippet in the java.nio packages [v6]
Roger Riggs
rriggs at openjdk.org
Thu May 11 16:28:18 UTC 2023
On Thu, 11 May 2023 02:16:48 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Convert the `<pre>{@code ...}</pre>` and some other patterns to `{@snippet ..}`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8307409: Update after scanning java.nio source tree
Looks good, just one suggestion. thanks for the careful updates.
src/java.base/share/classes/java/nio/X-Buffer.java.template line 1062:
> 1060: * {@snippet lang=java :
> 1061: * for (int i = offset, j = index; i < offset + length; i++, j++)
> 1062: * dst.put(j, src.get(i));
Indent to be consistent with the rest of the file.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13870#pullrequestreview-1422836527
PR Review Comment: https://git.openjdk.org/jdk/pull/13870#discussion_r1191324067
More information about the nio-dev
mailing list