RFR: 8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir [v2]

Alan Bateman alanb at openjdk.org
Fri May 12 18:03:45 UTC 2023


On Fri, 12 May 2023 17:45:47 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Return `dir`, not `dir::toAbsolutePath`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8307976: Initialize absDir to dir

test/jdk/java/nio/file/Files/CreateDirectories.java line 130:

> 128:         temp.toFile().deleteOnExit();
> 129:         Path a = Files.createDirectories(temp);
> 130:         assertFalse(a.isAbsolute(), a + " should not be absolute");

The correct assertion here is that a == temp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13959#discussion_r1192659358


More information about the nio-dev mailing list