RFR: JDK-8320168: handle setsocktopt return values [v3]

[Alan Bateman]

On Fri, 17 Nov 2023 08:07:02 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hi Alan, do you want an additional change to src/java.base/windows/native/libnio/ch/WindowsAsynchronousServerSocketChannelImpl.c ? Was not really sure about this after your comment about this chunk .

I think it's okay. The only concern now will be third party LSPs but it would be months or years before such issues come out of the woodwork, so I think what you have in the WindowsAsynchronous* files is okay, just check for SOCKET_ERROR instead of < 0.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16684#issuecomment-1816055621