RFR: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out [v4]
Jaikiran Pai
jpai at openjdk.org
Fri Nov 17 10:32:34 UTC 2023
On Thu, 16 Nov 2023 16:49:46 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here a fix for a timeout issue observed in DatagramChannel/Connect.java
>>
>> The suspicion is that the responder may have received some message from some other source and replied to that, leaving the initiator waiting forever.
>>
>> The proposed fix makes sure the messages exchanged are unique and identifiable and ensure that both the initiator and responder will discard any message that do not have the expected content.
>>
>> Additional logging should help with diagnosis if the test fails again.
>
> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
>
> - Responder: try { } finally { } should be around while () { }
> - Misplaced trace in finally block
Thank you Mark and Daniel for those inputs. The changes look good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16661#pullrequestreview-1736582958
More information about the nio-dev
mailing list