RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v3]

Severin Gehwolf sgehwolf at openjdk.org
Mon Oct 2 13:11:17 UTC 2023


On Fri, 29 Sep 2023 18:07:49 GMT, David Voit <duke at openjdk.org> wrote:

>> Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains three new commits since the last revision:
>> 
>>  - Wrap copy_statx_attributes with ifdef __linux__
>>  - Fix compile warnings.
>>  - 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
>
> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 212:
> 
>> 210: 
>> 211: #if defined(_DARWIN_FEATURE_64_BIT_INODE) || defined(__linux__)
>> 212: static jfieldID attrs_st_birthtime_sec;
> 
> birthtime_nsec missing? Just set it to zero on darwin and use the value under linux?

I've deliberately omitted that change here, not sure if this change of behaviour is wanted as it would add a field in `UnixFileAttributes` (it was part of the v2 patch). @bplb @AlanBateman Thoughts? I can include it of course, but don't want to go in circles.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1342671545


More information about the nio-dev mailing list