RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v5]

[Severin Gehwolf]

On Tue, 3 Oct 2023 10:09:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add support for nano seconds for btime on Linux
>
> src/java.base/unix/classes/sun/nio/fs/UnixFileAttributes.java line 28:
> 
>> 26: package sun.nio.fs;
>> 27: 
>> 28: import java.nio.file.attribute.BasicFileAttributes;
> 
> I assume you'll update the copyright date on this file.

OK.

> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 140:
> 
>> 138:             return (boolean)supportsBirthTime.invoke(null);
>> 139:         } catch (Throwable e) {
>> 140:             throw new RuntimeException("Illegal state!");
> 
> I agree with Brian, we need to find a better way to do this.

Sure, happy to. Any suggestions?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1343956701
PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1343955999