RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v5]

Severin Gehwolf sgehwolf at openjdk.org
Tue Oct 3 11:47:43 UTC 2023


On Tue, 3 Oct 2023 10:11:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Can you replace this with #if defined(__linux) .. #else .. #endif as it will make it easier to read.

I'm not sure I follow. We need the `statx` code *and* the old `stat64` code on Linux as that's the fall-back code when `statx` isn't supported. We don't need the `statx` code on other platforms. If I used `#if defined(__linux__) ... #else ... #endif` instead, I wouldn't get the stat64 code on Linux without duplication. What am I missing?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1343966374


More information about the nio-dev mailing list