RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v8]

Brian Burkhalter bpb at openjdk.org
Wed Oct 4 00:15:01 UTC 2023


On Tue, 3 Oct 2023 18:08:11 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Link libCreationTimeHelper with -ldl
>>  - Merge branch 'master' into JDK-8316304-statx-create-time-new
>>  - Cleanup UnixNativeDispatcher.c
>>  - Refactor test so as to not use reflection
>>  - Fix indents
>>  - Check correct fieldID
>>  - Add copyright
>>  - Add support for nano seconds for btime on Linux
>>  - Fix style
>>  - Wrap copy_statx_attributes with ifdef __linux__
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/6e6821d7...83347ec1
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 33:
> 
>> 31: {
>> 32: #if defined(__linux__)
>> 33:     void* statx_func = dlsym(RTLD_DEFAULT, "statx");
> 
> For commit 04226fd470bc9a238e83606cb7f62ebd64d44421, which is the penultimate commit, I am seeing the build error:
> 
> 
> open/test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c:33: error: undefined reference to 'dlsym'```

The above build failure is fixed in commit 83347ec1c9fee2a859470fff8e391c5f6970d226.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1344900913


More information about the nio-dev mailing list