RFR: 8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException [v4]

[Lance Andersen]

On Thu, 5 Oct 2023 20:18:44 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> The change #15501 removed explicit throwing of a `FileAlreadyExistsException` in `copyToForeignTarget` for non-directories when the target exists and `REPLACE_EXISTING` is not specified, instead relying on `FileChannel.open` eventually to throw this exception. The test, however, reuses the same file path, and on Windows `CreateFile`, which is invoked by `open`, can throw an `AccessDeniedException` if the file exists and has been marked for deletion but not yet actually deleted. This change proposes to reinstate explicitly throwing a FAEE.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8317128: Move read check outside replaceExisting c conditional

looks Ok to me

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15991#pullrequestreview-1660654539