RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v11]

Severin Gehwolf sgehwolf at openjdk.org
Mon Oct 9 13:12:58 UTC 2023


> Please review this nio change which adds `BasicFileAttributes.creationTime()` support for Linux by means of the `statx` Linux specific system call. The patch does a dynamic lookup of the function and if it is available, uses it to set the support birth time capability in `UnixNativeDispatcher`. When `statx` is not available, it won't use it and fall back to the old behaviour on such systems. It should, however, compile fine on Linux systems not supporting the `statx` system call.
> 
> Testing:
> - [x] GHA (MacOS X failure seems unrelated)
> - [x] `java.nio` tests.
> - [x] Manual builds and tests on older glibc versions (2.17 => fallback, 2.28+ => works). Compiles fine and falls back to the not supported case as it was before this patch.
> 
> Thoughts?

Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:

 - Keep wrapper function signature compatible to statx
 - Refactor test so as to use Linker from JEP 454.
   
   @enablePreview still needed as of yet. This can go once
   JDK-8312522 integrates.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15792/files
  - new: https://git.openjdk.org/jdk/pull/15792/files/ad428030..1c4cac36

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15792&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15792&range=09-10

  Stats: 86 lines in 5 files changed: 2 ins; 76 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/15792.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15792/head:pull/15792

PR: https://git.openjdk.org/jdk/pull/15792


More information about the nio-dev mailing list