RFR: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS [v2]

Brian Burkhalter bpb at openjdk.org
Mon Oct 9 19:00:05 UTC 2023


On Sat, 7 Oct 2023 06:22:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8317687: Return false for "unix" view of FAT
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 107:
> 
>> 105:         if (type == PosixFileAttributeView.class &&
>> 106:             entry().fstype().equals("msdos"))
>> 107:             return false;
> 
> I suspect supportsFileAttributeView(String) will need to be changed to return false if the view name is "unix".

Yes. Changed in 0cc942c2c3d888cf90f7fcc0dd8fb6c50de616cf.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16084#discussion_r1350697416


More information about the nio-dev mailing list