RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v11]
Brian Burkhalter
bpb at openjdk.org
Mon Oct 9 19:38:02 UTC 2023
On Mon, 9 Oct 2023 13:12:58 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this nio change which adds `BasicFileAttributes.creationTime()` support for Linux by means of the `statx` Linux specific system call. The patch does a dynamic lookup of the function and if it is available, uses it to set the support birth time capability in `UnixNativeDispatcher`. When `statx` is not available, it won't use it and fall back to the old behaviour on such systems. It should, however, compile fine on Linux systems not supporting the `statx` system call.
>>
>> Testing:
>> - [x] GHA (MacOS X failure seems unrelated)
>> - [x] `java.nio` tests.
>> - [x] Manual builds and tests on older glibc versions (2.17 => fallback, 2.28+ => works). Compiles fine and falls back to the not supported case as it was before this patch.
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
>
> - Keep wrapper function signature compatible to statx
> - Refactor test so as to use Linker from JEP 454.
>
> @enablePreview still needed as of yet. This can go once
> JDK-8312522 integrates.
Nice to see the test C code gone.
-------------
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15792#pullrequestreview-1665154207
More information about the nio-dev
mailing list