RFR: 8316927: JFR: Move shouldCommit check earlier for socket events

Daniel Fuchs dfuchs at openjdk.org
Thu Oct 12 14:02:04 UTC 2023


On Mon, 25 Sep 2023 16:57:46 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> The events for socket read and socket write retrieves the remote address even in cases where the event didn't exceed the threshold. By moving the shouldCommit check earlier, it can be avoided. 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

LGTM - I was expecting @tprinzing to review too, but yes you can integrate if you want.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15908#pullrequestreview-1674252334


More information about the nio-dev mailing list