RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v2]

Shaojin Wen duke at openjdk.org
Tue Oct 17 03:22:56 UTC 2023


> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to use try...catch to handle CharacterCodingException and throw IllegalArgumentException instead of CharacterCodingException to make the calling code cleaner.

Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:

  fix from @liach 's review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16209/files
  - new: https://git.openjdk.org/jdk/pull/16209/files/aa76c505..d2063b08

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16209&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16209&range=00-01

  Stats: 9 lines in 2 files changed: 4 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16209/head:pull/16209

PR: https://git.openjdk.org/jdk/pull/16209


More information about the nio-dev mailing list