RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v2]
Claes Redestad
redestad at openjdk.org
Tue Oct 17 09:34:22 UTC 2023
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix from @liach 's review
>
> The thrown CCE was intended for `Files.readString` and `Files.writeString`, and is in reality, only used by those 2 sites. However, you missed updating those sites, so they now throw IAE instead of CCE, which should be fixed.
I agree with @liach that `Files.readString / writeString` should continue to throw `CCE`, not `IAE`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16209#issuecomment-1766035016
More information about the nio-dev
mailing list