RFR: 8314891: Additional Zip64 extra header validation [v7]

[Sean Coffey]

On Mon, 18 Sep 2023 13:17:25 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Please review this PR which improves the Zip64 extra header validation:
>> 
>> - Throw a ZipException If the extra len field is 0 and :
>> -- size, csize, or loc offset are set to 0xFFFFFFFF
>> -- disk starting number is set to 0xFFFF
>> 
>> - We have a valid size for the Zip64 extra header but we are missing the csize or loc fields if they are expected to be part of the header
>> 
>> Mach5 tiers 1-3 are clean
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing space

Looks good to me Lance. I note that the extra checks aren't reversed via any sort of system property but given that this fix isn't planned for JDK update releases, that seems fine to me.

early testing by frameworks which create/modify custom zip files will be important.

-------------

Marked as reviewed by coffeys (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15650#pullrequestreview-1685425990