RFR: 8306308: (ch) Writer created by Channels::newWriter may lose data [v3]
Brian Burkhalter
bpb at openjdk.org
Thu Oct 19 22:26:14 UTC 2023
On Thu, 19 Oct 2023 07:37:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8306308: Add some code to dispense with lock
>
> src/java.base/share/classes/sun/nio/cs/StreamEncoder.java line 249:
>
>> 247: private final int maxBufferCapacity;
>> 248:
>> 249: // This must be non-null
>
> I think you can drop that comment now, it only made sense when one is non-null.
Dropped in cbf23b9f2942a5315bc160f0f653348c0d3aeee7.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16207#discussion_r1366197318
More information about the nio-dev
mailing list