RFR: 8306308: (ch) Writer created by Channels::newWriter may lose data [v3]
Brian Burkhalter
bpb at openjdk.org
Thu Oct 19 23:46:04 UTC 2023
On Thu, 19 Oct 2023 07:50:32 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> BTW: Do we have tests with SocketChannels configured non-blocking that will check that IllegalBlockingMode is thrown?
>
>> Do we have tests with SocketChannels configured non-blocking that will check that IllegalBlockingMode is thrown?
>
> I don't believe we do; the code attached to the JBS ticket suggests that we did not throw, so if we had such a test, it would be failing.
The test I added is just the reproducers attached by @djelinski (thanks!) to the JDK-8306308 issue aggregated into a single JUnit 5 test. Both sub-tests fail when run against the master branch, but pass with the proposed change applied.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16207#issuecomment-1771846044
More information about the nio-dev
mailing list