RFR: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter [v2]

Brian Burkhalter bpb at openjdk.org
Tue Oct 24 16:36:53 UTC 2023


On Tue, 24 Oct 2023 08:43:09 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8318677: Adjust minBufferap verbiage
>
> src/java.base/share/classes/java/nio/channels/Channels.java line 427:
> 
>> 425:      *
>> 426:      * @implNote
>> 427:      * The implementation may ignore the value of {@code minBufferCap} provided.
> 
> I think we'll need to adjust the specification of parameter too, something like "may be ignored".
> 
> For the implNote I think it can just sat that minBufferCap is ignored.

Adjusted in 5f93e5776474cc286ea32963fb55bf05cf6ce22f.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16325#discussion_r1370502955


More information about the nio-dev mailing list