RFR: 8318677: (ch) Add implNote about minBufferCap to main variant of Channels.newWriter [v3]

Roger Riggs rriggs at openjdk.org
Wed Oct 25 13:28:32 UTC 2023


On Tue, 24 Oct 2023 23:25:47 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add an `implNote` about the `minBufferCap` parameter of the three-arg `Channels.newWriter` and slightly tweak the test.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8318677: Correct the faux pas of the previous commit

src/java.base/share/classes/java/nio/channels/Channels.java line 538:

> 536:      *         The minimum capacity of the internal byte buffer,
> 537:      *         or {@code -1} if an implementation-dependent
> 538:      *         default capacity is to be used; may be ignored

I'm not understanding this. The implNote says it *is* ignored, the annotation on the @param says *may*.


     *         The minimum capacity of the internal byte buffer,
     *         or {@code -1} if an implementation-dependent default capacity is to be used.
     *         The minimum capacity is ignored.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16325#discussion_r1371758054


More information about the nio-dev mailing list