RFR: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow [v6]
Alan Bateman
alanb at openjdk.org
Wed Sep 20 07:12:45 UTC 2023
On Tue, 19 Sep 2023 20:03:57 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> In `ChannelInputStream` and `ChannelOutputStream`, process small chunks of bytes in sequence to avoid running afoul of the `MaxDirectMemorySize`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8316156: Revert BufferedInputStream changes; update test
The change to BAIS.tranfserTo write at most 128k at a time looks okay. The test looks okay and I assume you've checked the test is stable with 5Mb.
The PR description is a bit outdated now, I assume you can edit that so it aligns with what this change is about.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15733#pullrequestreview-1634825723
More information about the nio-dev
mailing list