RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux

Alan Bateman alanb at openjdk.org
Sun Sep 24 17:21:10 UTC 2023


On Thu, 21 Sep 2023 17:38:43 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Thanks for your input! Here is an updated patch, now using LinuxFileSystemProvider and the logic to use `statx` is now in the linux specific directory trees. The fallback code is unchanged (using `UnixNativeDispatcher`). This version never uses both `stat64` and `statx`. It only uses `statx` if its available and uses the older `stat64` otherwise.

I was chatting with @bplb about this change, mostly about testing and maintainability. We both agreed that this PR isn't the right place to do the refactoring, there is a lot disruptive changes needed to allow overriding of what is currently in the Unix* code. So if it's okay with you, we think go back the original/smaller change in UnixNativeDispatcher.c but use stat or statx, before both, as you have in the second iteration. Would that be okay with you?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15792#issuecomment-1732623818


More information about the nio-dev mailing list