RFR: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT [v2]

Fabian Meumertzheim duke at openjdk.org
Thu Apr 11 14:04:43 UTC 2024


On Thu, 11 Apr 2024 12:38:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> If this system property is going to be used outside of the JDK testing then it will need to be renamed to a jdk.* property and we'll need to create a CSR.

I renamed it to `jdk.nio.file.maxWatchEvents`, is that what you would expect?

Is a CSR something I can create myself? I followed the linked docs but it looks like I can't to do much without an OpenJDK account.

> Also the implementation should use GetPropertyAction.privilegedGetProperty.

Done.

> test/jdk/java/nio/file/WatchService/LotsOfEntries.java line 39:
> 
>> 37: import java.util.stream.Collectors;
>> 38: 
>> 39: public class LotsOfEntries {
> 
> What platforms have you tested this on? I'm concerned that it may fail intermittently on some platforms/configurations.

It passes on Linux and macOS, I am in the process of testing it on Windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18739#discussion_r1561074799
PR Review Comment: https://git.openjdk.org/jdk/pull/18739#discussion_r1561075354


More information about the nio-dev mailing list