RFR: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel

[Jaikiran Pai]

On Tue, 16 Apr 2024 12:03:07 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

> Please oblige and review the following changes (provided by Alan Bateman) which addresses the issue outlined in
> JDK-8329190: DatagramChannel.receive should throw ClosedChannelException when called on closed channel 
> 
> This ensures that a ClosedChannelException is consistently thrown from DatagramChannel send and receive methods, especially in the context of asynchronous closure and calling thread interruption.
> 
> The change is to move the ensureOpen() method call, which checks that a channel has not been closed, to the start of read/write send/receive methods on the DatagramChannel
> 
> The regression suites for jdk_nio and jdk_net and the JCK tests for api/java_nio api/java_net have been executed in repeat mode, multiple times, without any observed relevant failures.

test/jdk/java/nio/channels/Channels/ClosedNetworkChannels.java line 64:

> 62:             fail();
> 63:         } catch (AsynchronousCloseException e) {
> 64:             fail(e + " thrown");

I think for debugging any unexpected failures, it might be better to include the original exception too in the failure. Like:

fail(e + " thrown", e);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18796#discussion_r1567426208