RFR: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel

[Jaikiran Pai]

On Tue, 16 Apr 2024 15:32:24 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> test/jdk/java/nio/channels/Channels/ClosedNetworkChannels.java line 64:
>> 
>>> 62:             fail();
>>> 63:         } catch (AsynchronousCloseException e) {
>>> 64:             fail(e + " thrown");
>> 
>> I think for debugging any unexpected failures, it might be better to include the original exception too in the failure. Like:
>> 
>> fail(e + " thrown", e);
>
> yes, that is a reasonable suggestion. I will, if you don't mind, leave things as is, for the simple reason, I would need to submit such a change on repeat mode through MACH5, as it's for unexpected exceptions, and this can take 5/6 days for the job to get through MACH5, depending on resource availability, and I have gone through that cycle three times already for this fix

Leaving it in the current form is OK with me. We can revisit that line if/when we modify this test later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18796#discussion_r1567576750