RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

Alan Bateman alanb at openjdk.org
Thu Apr 18 13:42:05 UTC 2024


On Wed, 17 Apr 2024 01:34:07 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>> Currently the JFR event FileForceEvent is generated by instrumenting the sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer mirror events with static methods.
>> 
>> Added the event at jdk.internal.event.FileForceEvent, and changed jdk.jfr.events.FileForceEvent to be a mirror event.
>> 
>> Updated FileChannelImpl to use the jdk internal event static methods, and removed the force() method from FileChannelImplInstrumentor.
>> 
>> Uses the existing tests.
>
> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test file local to test

My comments have been addressed and I don't have any else to add. I assume @egahlin will cast an eye over this too.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18542#pullrequestreview-2008938324


More information about the nio-dev mailing list