RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

Tim Prinzing tprinzing at openjdk.org
Thu Apr 18 15:16:59 UTC 2024


On Thu, 18 Apr 2024 14:32:28 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 66:
>> 
>>> 64:         FileWriteEvent.class,
>>> 65:         SocketReadEvent.class,
>>> 66:         SocketWriteEvent.class,
>> 
>> I'm guessing that this change which remove these two event classes is a drive-by-cleanup that should actually have been done with some previous fix in this area?
>> Just wanted to double check it was intended as it doesn't seem to be related to file events.
>
> I think it might be the cause for https://bugs.openjdk.org/browse/JDK-8329330 I have sent out a PR to remove those separately so the fix can be backported. https://github.com/openjdk/jdk/pull/18843

That's correct, it is an unrelated cleanup (other than it seems to cause tests to fail now).  @egahlin, do you want me to remove those from this PR?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18542#discussion_r1570953838


More information about the nio-dev mailing list