RFR: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT [v8]

Fabian Meumertzheim duke at openjdk.org
Thu Apr 18 18:45:59 UTC 2024


On Thu, 18 Apr 2024 18:22:45 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> I slightly lowered/raised the numbers of files to be created. We can tune this more if needed, I don't think fully precise control over the number of events is required.
>
> We just don't want to have random failures creating noise. Tests are run many times each day. I think the problematic line here is
> 
>  32  * @run main/othervm -Djdk.nio.file.WatchService.maxEventsPerPoll=5 LotsOfEntries 5 pass
> 
> This failed I think in only 3 of 300 repeats on linux-aarch64.

Yes what I meant is that the numbers in the test are essentially arbitrary. Now that they are further away from the limit, I would expect failures to be less likely. But if there are still failures, I can make the difference even larger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18739#discussion_r1571209754


More information about the nio-dev mailing list