RFR: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT [v12]

Brian Burkhalter bpb at openjdk.org
Tue Apr 23 01:33:39 UTC 2024


On Mon, 22 Apr 2024 18:39:26 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> The implNote in WatchService looks okay. The change to AbstractWatchKey looks okay, just a bit overkill in the clamping. The test looks like it will take a few iterations to be stable so I'll stay out of that for now.
>
>> The test looks like it will take a few iterations to be stable so I'll stay out of that for now.
> 
> Yes, I think it needs to be ascertained why the test has been failing in some cases and actually fix it as opposed to just tweaking the parameters.

> @bplb If you think that this approach is reasonable, could you rerun the test?

This update passed 400 iterations on linux-aarch64 and 100 on each of linux-x64, macosx-x64, and windows-x64.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18739#issuecomment-2071246418


More information about the nio-dev mailing list