RFR: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT [v13]
Fabian Meumertzheim
duke at openjdk.org
Wed Apr 24 08:21:32 UTC 2024
On Tue, 23 Apr 2024 17:53:52 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Attemp to deflake test and add better output on failures
>
> src/java.base/share/classes/java/nio/file/WatchService.java line 109:
>
>> 107: * scan a watched directory to get an updated list of the files in the
>> 108: * directory. The limit for the pending events can be changed from its default
>> 109: * with the system property {@code jdk.nio.file.WatchService.maxEventsPerPoll}
>
> @fmeum On this line 109, would you please change `@code` to `@systemProperty`?
>
>
> --- a/src/java.base/share/classes/java/nio/file/WatchService.java
> +++ b/src/java.base/share/classes/java/nio/file/WatchService.java
> @@ -106,7 +106,8 @@
> * special event is the trigger to re-examine the state of the object, e.g.
> * scan a watched directory to get an updated list of the files in the
> * directory. The limit for the pending events can be changed from its default
> - * with the system property {@code jdk.nio.file.WatchService.maxEventsPerPoll}
> + * with the system property
> + * {@systemProperty jdk.nio.file.WatchService.maxEventsPerPoll}
> * set to a value that parses as a positive integer. This may be useful in
> * environments where there is a high volume of changes and where the impact
> * of discarded events is high.
> * ```
Thanks, I didn't even know about this tag.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18739#discussion_r1577482151
More information about the nio-dev
mailing list