RFR: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect [v3]

Alan Bateman alanb at openjdk.org
Thu Aug 1 06:22:32 UTC 2024


On Wed, 31 Jul 2024 18:45:02 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Replace differences of milliseconds vs. epoch to differences of nanoseconds per the JVM's high-resolution time source.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8334405: Update limits on expected duration as suggested

I think this is looks okay and the tolerances are good. There is course a risk that the timer used by the OS (for timed poll) may have issues but their isn't anything we do about that.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20398#pullrequestreview-2211741226


More information about the nio-dev mailing list