RFR: 8337716: ByteBuffer hashCode implementations are inconsistent [v2]

[Brian Burkhalter]

On Sat, 3 Aug 2024 19:08:03 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8337716: Statically import StandardOpenOption; rem remove spurious line break
>
> test/jdk/java/nio/Buffer/EqualsCompareTest.java line 732:
> 
>> 730:         Files.write(path, bytes);
>> 731:         try (FileChannel fc = FileChannel.open(path, StandardOpenOption.READ,
>> 732:             StandardOpenOption.DELETE_ON_CLOSE)) {
> 
> If you statically import StandardOpenOption then it might be more readable.

Fixed in ba25d55.

> test/jdk/java/nio/Buffer/EqualsCompareTest.java line 734:
> 
>> 732:             StandardOpenOption.DELETE_ON_CLOSE)) {
>> 733:             MappedByteBuffer one =
>> 734:                 fc.map(FileChannel.MapMode.READ_ONLY, 0, bytes.length);
> 
> Spurious line break here.

Fixed in ba25d55.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20451#discussion_r1702863682
PR Review Comment: https://git.openjdk.org/jdk/pull/20451#discussion_r1702863701