RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

[Brian Burkhalter]

On Mon, 5 Aug 2024 15:37:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> make/modules/java.base/lib/CoreLibraries.gmk line 57:
>> 
>>> 55:     OPTIMIZATION := HIGH, \
>>> 56:     EXTRA_HEADER_DIRS := \
>>> 57:         libnio/ch, \
>> 
>> This will introduce a source code dependency from libjava to libnio. It might be the correct thing to do, but I just want to highlight this. 
>> 
>> Maybe the libnio/ch code also should move to libjava? Or, perhaps at least the header files. Conceptually, I'd feel better about having a dependency on libnio as a "downstream" library on libjava source code, than the other way around.
>
>> This will introduce a source code dependency from libjava to libnio. It might be the correct thing to do, but I just want to highlight this.
> 
> I'll look into improving it.

Fixed in 7e8a02e

>> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>> 
>>> 69:         -framework Foundation \
>>> 70:         -framework SystemConfiguration, \
>>> 71:     LIBS_windows := advapi32.lib ole32.lib shell32.lib version.lib mswsock.lib ws2_32.lib, \
>> 
>> Please keep libraries alphabetically sorted.
>
> Thanks for pointing this out; I will fix it.

Fixed in 7e8a02e.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1707325897
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1707326484