RFR: 8338630: Test java/nio/channels/DatagramChannel/SendReceiveMaxSize.java timeout [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed Aug 21 14:17:04 UTC 2024
On Wed, 21 Aug 2024 12:45:22 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi,
>> On linux test environments which has docker service, `ifconfig` shows that `docker0` appears to be a virtual ethernet bridge which is created by the docker host. And the `docker0` virtual ethernet bridge may cause test `java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` bind `docker0` ander network port.
>> I think we should just skip "docker0" interfaces when looking for an IPv4 address for tests.
>> Change has been verified, test fix only, the risk is low.
>
> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>
> - macos may have docker0 interface
> - macos may have docker0 interface
I'd rather avoid adding exceptions until it's proven necessary. I don't know if `docker` uses the same techniques on macOs and Linux to configure private networks between instances. But since it's unlikely that the name `docker0` would be reused for something else then maybe we can keep this change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20658#issuecomment-2302161322
More information about the nio-dev
mailing list