RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) [v2]

Brian Burkhalter bpb at openjdk.org
Wed Aug 21 14:50:21 UTC 2024


On Wed, 21 Aug 2024 09:48:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> I guess is okay although I think I'd much prefer to decide this in the Java code. Maybe we can re-examine this again in the future.

Sure. I think it would be good to get this in now, however, due to backward compatibility.

> Minor nit, can you use the same comment style as the other comments in the code, meaning drop the empty comment lines, only to keep it consistent with the other comments in this function and elsewhere.

Fixed in 347e906.

Do you agree that a CSR is warranted?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20655#discussion_r1725190816


More information about the nio-dev mailing list