RFR: 8324048: (fc) Make FileKey fields final

Brian Burkhalter bpb at openjdk.org
Wed Aug 21 16:08:06 UTC 2024


On Wed, 21 Aug 2024 13:28:27 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Replace use of IDs to set FileKey fields from native with passing down an array, at the expense of an array allocation.
>
> src/java.base/windows/classes/sun/nio/ch/FileKey.java line 67:
> 
>> 65: 
>> 66:     static {
>> 67:         IOUtil.load();
> 
> I assume you verified that `IOUtil.load()` won't be needed, correct?

I tested back before I opened this PR but will test again. There is no longer any code in these classes which uses upcalls from native code. The only native functions remaining from what I can see are `fdval()` and `handleval()` which are defined in `libjava` {`libjava.so`, `libjava.dylib`, `java.dll`}.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20429#discussion_r1725356549


More information about the nio-dev mailing list