RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) [v2]

[Brian Burkhalter]

On Wed, 21 Aug 2024 16:07:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> I guess is okay although I think I'd much prefer to decide this in the Java code. Maybe we can re-examine this again in the future.
>> 
>> Sure. I think it would be good to get this in now, however, due to backward compatibility.
>> 
>>> Minor nit, can you use the same comment style as the other comments in the code, meaning drop the empty comment lines, only to keep it consistent with the other comments in this function and elsewhere.
>> 
>> Fixed in 347e906.
>> 
>> Do you agree that a CSR is warranted?
>
>> Do you agree that a CSR is warranted?
> 
> FWIW, the original change didn't have a CSR (only had a release note), so I'm somewhat confused this would need one.

It should have as there was a behavioral change: creation time changed from last modified time to epoch when the birth time is not available.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20655#discussion_r1725385972