RFR: 8338630: Test java/nio/channels/DatagramChannel/SendReceiveMaxSize.java timeout [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Aug 23 06:26:04 UTC 2024
On Wed, 21 Aug 2024 12:45:22 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi,
>> On linux test environments which has docker service, `ifconfig` shows that `docker0` appears to be a virtual ethernet bridge which is created by the docker host. And the `docker0` virtual ethernet bridge may cause test `java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` bind `docker0` ander network port.
>> I think we should just skip "docker0" interfaces when looking for an IPv4 address for tests.
>> Change has been verified, test fix only, the risk is low.
>>
>> Additional testing
>>
>> - [x] full jtreg test on linux x64
>> - [x] full jtreg test on linux aarch64
>
> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>
> - macos may have docker0 interface
> - macos may have docker0 interface
Thank you for running those tests. I ran tier1, tier2 and tier3 in our CI too with these changes and it looks fine. I'll go ahead and sponsor this now.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20658#issuecomment-2306376326
More information about the nio-dev
mailing list