RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Aug 26 08:06:03 UTC 2024
On Sat, 24 Aug 2024 10:50:36 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> On alinux3(alibaba cloud linux version 3) system, the `/tmp` disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).
>>
>> Before this PR, this test [check](https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L110) if there is `statx` system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is `tmpfs`. When the tested filesystem type is `tmpfs`, then the tested file doesn't support birth time.
>>
>> Test fix only, the change has been verified, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> merge Linker.nativeLinker().defaultLookup().find("statx").isPresent() and !Files.getFileStore(file).type().contentEquals("tmpfs")
test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 115:
> 113: if (statxIsPresent && !Files.getFileStore(file).type().contentEquals("tmpfs")) {
> 114: supportsCreationTimeRead = true;
> 115: }
Noting here that the test could still fail on some other filesystem which might not support birth time. For example `nfs` on Linux (IIRC).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1730857124
More information about the nio-dev
mailing list