RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v4]
SendaoYan
syan at openjdk.org
Mon Aug 26 13:17:45 UTC 2024
> Hi all,
> On alinux3(alibaba cloud linux version 3) system, the `/tmp` disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).
>
> Before this PR, this test [check](https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L110) if there is `statx` system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is `tmpfs`. When the tested filesystem type is `tmpfs`, then the tested file doesn't support birth time.
>
> Test fix only, the change has been verified, no risk.
SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
- delete import java.io.BufferedReader; and -import java.io.InputStreamReader;
- revert "use stat -c linux command line to determise support create time or not", and set nfs not suoport create time
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20687/files
- new: https://git.openjdk.org/jdk/pull/20687/files/1614f8ee..4dcdf247
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20687&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20687&range=02-03
Stats: 25 lines in 1 file changed: 2 ins; 21 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/20687.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20687/head:pull/20687
PR: https://git.openjdk.org/jdk/pull/20687
More information about the nio-dev
mailing list