RFR: 8345432: (ch, fs) Replace anonymous Thread with InnocuousThread [v2]

Brian Burkhalter bpb at openjdk.org
Thu Dec 12 16:45:12 UTC 2024


On Thu, 12 Dec 2024 16:29:42 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/share/classes/sun/nio/fs/Cancellable.java line 121:
>> 
>>> 119:      */
>>> 120:     static void runInterruptibly(Cancellable task) throws ExecutionException {
>>> 121:         Thread t = InnocuousThread.newThread("NIO-Task", task);
>> 
>> "NIO-Task" doesn't make sense as the thread name here, something like "CancellableOp" is closer to what it really is.
>> 
>> As you are there, the javadoc link to runInterruptibly is missing the "#", maybe we can fix this while we are here.
>
> I just left the name as it was but will change it as suggested and fix the link.

Changed in 7a421c1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22697#discussion_r1882506841


More information about the nio-dev mailing list