RFR: 8345432: (ch, fs) Replace anonymous Thread with InnocuousThread [v3]
Alan Bateman
alanb at openjdk.org
Tue Dec 17 07:43:43 UTC 2024
On Tue, 17 Dec 2024 01:03:12 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Change internal instances of anonymous `Thread`s to instances of `InnocuousThread`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8345432: Add uninterruptible InnocuousThread for Windows PipeImpl
src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 64:
> 62: return createThread(newName(), target, 0L,
> 63: ClassLoader.getSystemClassLoader(), -1, true);
> 64: }
I think this is just a bit weird to have this in InnocuousThread. I think we should look for alternatives for PipeImpl so leave it out of this PR as it's benign if it inherits.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22697#discussion_r1888033316
More information about the nio-dev
mailing list