RFR: 8324539: Do not use LFS64 symbols in JDK libs [v4]

Magnus Ihse Bursie ihse at openjdk.org
Thu Feb 1 16:21:05 UTC 2024


On Thu, 1 Feb 2024 12:13:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Can you confirm that you've run tier1-4 at least? Some of the library code that is changed here is not tested in the lower tiers.

I have run tier1-4 now, and it passes (bar the tests that are currently failing in mainline). However, this only tests 64-bit builds, and these changes do not affect 64-bit builds, only 32-bit linux. So the tier1-4 is more of a sanity check that I did not inadvertenly broke any 64-bit code.

To really test that this works properly, a 32-bit linux with an assortment of operations on > 2GB files would be needed. To the best of my knowledge, we have no such test environment available, and I could not even try to think of how to create such a test setup that does anything useful. (That is, if I even were to spend any time on creating new tests for 32-bit platforms...)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1921697168


More information about the nio-dev mailing list