RFR: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows

Lance Andersen lancea at openjdk.org
Sun Feb 4 18:18:00 UTC 2024


On Sun, 4 Feb 2024 16:22:14 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Can I please get a review for this trivial change to disable the test `TestPosix.setPermissionsShouldConvertToUnix`?
> 
> This test was recently introduced in [JDK-8324635](https://bugs.openjdk.org/browse/JDK-8324635), but fails intermittently on Windows CI runs. (See [JDK-8325199](https://bugs.openjdk.org/browse/JDK-8325199))
> 
> To reduce CI noise, I suggest we simply add `@Disabled` for now on the failing test.  The actual fix of the failing test will be investigated and fixed as a follow-up PR.

Hi Eirik,

I think disabling the tests makes sense for now or perhaps just  disable for windows.

I think we should use a separate PR to disable the test and keep this bug open

-------------

PR Review: https://git.openjdk.org/jdk/pull/17700#pullrequestreview-1861535931


More information about the nio-dev mailing list