RFR: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows [v2]

Lance Andersen lancea at openjdk.org
Sun Feb 4 20:54:00 UTC 2024


On Sun, 4 Feb 2024 20:35:24 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Can I please get a review for this trivial change to disable the test `TestPosix.setPermissionsShouldConvertToUnix`?
>> 
>> This test was recently introduced in [JDK-8324635](https://bugs.openjdk.org/browse/JDK-8324635), but fails intermittently on Windows CI runs. (See [JDK-8325199](https://bugs.openjdk.org/browse/JDK-8325199))
>> 
>> To reduce CI noise, I suggest we simply add `@Disabled` for now on the failing test.  The actual fix of the failing test will be investigated and fixed as a follow-up PR.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Selectively skip the test only on Windows

Thank you for the update Eirik,  That looks good.  I would also link this bug to the open bug in JBS when you have a moment,

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17700#pullrequestreview-1861555802


More information about the nio-dev mailing list