RFR: JDK-8325189: Enable this-escape javac warning in java.base

[Magnus Ihse Bursie]

On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled.

Build changes look fine, but there is really a *lot* of places where the warning is individually disabled. This indicates either that the warning is too broad, or that the code base is potentially very buggy; neither of which sounds very good. :(

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17692#pullrequestreview-1865022402