RFR: JDK-8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
Daniel Fuchs
dfuchs at openjdk.org
Tue Feb 13 14:28:02 UTC 2024
On Tue, 13 Feb 2024 13:54:12 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> In case of a bad running LDAP we got this output from test test/jdk/java/nio/channels/unixdomain/SocketOptions.java
>
> java.lang.RuntimeException: wrong username
> at SocketOptions.testPeerCred(SocketOptions.java:75)
> at SocketOptions.main(SocketOptions.java:52)
> at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
> at java.base/java.lang.Thread.run(Thread.java:1583)
>
> It would be better to see the compared values (user name data we compare) and get them in the exception output.
Since this is a test the proposed changes look reasonable to me. @Michael-Mc-Mahon may have more comments. You may want to consider adding a line break to avoid long lines.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17829#pullrequestreview-1878089151
More information about the nio-dev
mailing list