RFR: JDK-8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case [v2]

Matthias Baesken mbaesken at openjdk.org
Tue Feb 13 14:59:13 UTC 2024


On Tue, 13 Feb 2024 14:43:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adjust output and header
>
> test/jdk/java/nio/channels/unixdomain/SocketOptions.java line 76:
> 
>> 74:                 if (!s1.equals(s2)) {
>> 75:                     throw new RuntimeException("wrong username, we got " + s1 + " but property user.name is " + s2);
>> 76:                 }
> 
> It might be better to use "expected" and "actual" instead of "we got" :-)
> 
> I assume you'll bump the copyright header before integrating.

Thanks, I adjusted the header and also the output.
Added a line break.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17829#discussion_r1488014167


More information about the nio-dev mailing list